added integer validator to validate int and changed number to validate numeric

joanpablo / reactive_forms

This is a model-driven approach to handling form inputs and validations, heavily inspired in Angular's Reactive Forms

MIT License

472 stars 90 forks source link

added integer validator to validate int and changed number to validate numeric #426

Closed Ch4rl3B closed 8 months ago

Ch4rl3B commented 1 year ago

Connection with issue(s)

Close #425

Solution description

Added IntegerValidator to validate integer numbers
Modified the NumberValidator
Unit tests

:warning: This might be a breaking change for some users.

obiwan007 commented 9 months ago

Any reason why this is not been merged?

joanpablo commented 8 months ago

BTW @Ch4rl3B @obiwan007 thanks for the contribution.

What do you think about the comments I left to you?

joanpablo commented 8 months ago

@Ch4rl3B @obiwan007 I'm closing this PR since version 17.0.0 brings changes to the Validator.number() validator. I'm still working on other changes that will be introduced in 17.0.0, so you can check the Validator in the develop branch.