joanpablo / reactive_forms

This is a model-driven approach to handling form inputs and validations, heavily inspired in Angular's Reactive Forms
MIT License
472 stars 90 forks source link

Reduce intl constraint to match flutter_localizations 3.16.0 #448

Closed kuhnroyal closed 6 months ago

kuhnroyal commented 7 months ago

Connection with issue(s)

See https://github.com/joanpablo/reactive_forms/commit/839968f596058c5466b61fd37a2dde56f03b4e29#r141272235

The flutter_localizations package from Flutter SDK 3.16.0 forces intl: 0.18.1 - see https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_localizations/pubspec.yaml#L11

Solution description

I reduced the constraint and added the flutter_localizations package as additional dependency to ensure this does not happen again. This should have no impact on consumers of the package as the Flutter SDK is already required.

Screenshots or Videos

To Do

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.01%. Comparing base (1a3c954) to head (827c895).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #448 +/- ## ======================================== Coverage 95.01% 95.01% ======================================== Files 67 67 Lines 1385 1385 ======================================== Hits 1316 1316 Misses 69 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joanpablo commented 6 months ago

Hey @kuhnroyal Thanks for the PR, but would you mind to remove the dependency to flutter_localizations and just lower the intl version? Thanks in advance

kuhnroyal commented 6 months ago

I added that explicitly to prevent the same problem in the future. This has zero impact on users of the reactive_forms as it is an SDK dependency which does not have to be downloaded and will get tree-shaken if not used.

If you still want me to remove it, let me know.