Closed kuhnroyal closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.01%. Comparing base (
1a3c954
) to head (827c895
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @kuhnroyal Thanks for the PR, but would you mind to remove the dependency to flutter_localizations and just lower the intl version? Thanks in advance
I added that explicitly to prevent the same problem in the future. This has zero impact on users of the reactive_forms as it is an SDK dependency which does not have to be downloaded and will get tree-shaken if not used.
If you still want me to remove it, let me know.
Connection with issue(s)
See https://github.com/joanpablo/reactive_forms/commit/839968f596058c5466b61fd37a2dde56f03b4e29#r141272235
The
flutter_localizations
package from Flutter SDK 3.16.0 forcesintl: 0.18.1
- see https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_localizations/pubspec.yaml#L11Solution description
I reduced the constraint and added the
flutter_localizations
package as additional dependency to ensure this does not happen again. This should have no impact on consumers of the package as the Flutter SDK is already required.Screenshots or Videos
To Do