search

joaorb64 / joycond-cemuhook

Support for cemuhook's UDP protocol for joycond devices
MIT License
139 stars 19 forks source link

No longer working with UPower 0.99.18 #63

Closed CommandMC closed 2 years ago

CommandMC commented 2 years ago

Hello, I'm running this on EndeavourOS (basically Arch Linux) & updated to kernel 5.17.8 yesterday. Today, when booting this up, I'm met with this stacktrace after connecting my controller (Switch Pro).

Full list of upgraded packages (most of them are probably irrelevant, but just in case)

I'm using the AUR package, but I was also able to reproduce the issue by following the "How to use" instructions in this repo

Let me know if you need anything else to help debug this

CommandMC commented 2 years ago

Update: This seems to be caused by a bug in the upower package on Arch. I've now downgraded from 0.99.18-1 to 0.99.17-1 for now, will report this to them in the coming days

CommandMC commented 2 years ago

I've now opened up https://gitlab.freedesktop.org/upower/upower/-/issues/190 to track the issue on UPower's side. Will re-open the issue if this is a deliberate change (which it seems not to be, considering their documentation still mentions this method)

joaorb64 commented 2 years ago

Hi! Sorry for not getting back to you in time. If this Refresh method was deprecated, we can definitely add a check and use the new function name if the user has this package in a newer version! But let's see what's their answer on the topic first, since you already have it working on your end.

CommandMC commented 2 years ago

This commit is probably what broke it

CommandMC commented 2 years ago

So uh, just to test, I've removed the two lines where Refresh is called and everything seems to still work?
Which makes me wonder why exactly it was called to begin with

CommandMC commented 2 years ago

Fixed with a82dbf7e23f9b9c5142034e75af9aae09d113822