Feat/optional velocity threshold

jobtoday / react-native-image-viewing

Tiny, purely TS, modal component for viewing images 🏙

https://exp.host/@antonkalinin/react-native-image-viewing

MIT License

892 stars 292 forks source link

Feat/optional velocity threshold #171

Open kanelloc opened 1 year ago

kanelloc commented 1 year ago

Summary

Added a new optional property swipeCloseVelocity to override the default valueSWIPE_CLOSE_VELOCITY

This PR solves the following issue: https://github.com/jobtoday/react-native-image-viewing/issues/165

kanelloc commented 1 year ago

Hey @antonKalinin 👋 Can you check this PR to solve the attached issue?

Thanks 😄

kanelloc commented 1 year ago

Hey @maksimko 👋 Can you check this PR to solve the attached issue? Thanks 😆

UchennaOkafor commented 1 year ago

@kanelloc

I wanted to use your branch, I did this in my packages.json file using yarn "react-native-image-viewing": "kanelloc/react-native-image-viewing#feat/optional_velocity_threshold",

but now the import isn't working. I am importing it like this import ImageView from "react-native-image-viewing";

but I am getting the following error message Cannot find module 'react-native-image-viewing' or its corresponding type declarations.ts(2307)

Do you know why? Thanks

seferdemirci commented 1 year ago

@antonKalinin please merge it