search

joedixon / nova-translation

53 stars 17 forks source link

Same route names in package and dependency package #21

Open Magarif opened 4 years ago

Magarif commented 4 years ago

This package contains the same route names as in the dependency package, which is laravel-translation. In order to keep this package compatible with the Laravel 7+ and to be able to cache routes with route:cache command, Laravel expects unique route names which is currently not the case. This could lead to a performance issue on huge sites and is a drawback as there is no framework version constraint mentioned in the documentation. Could this, please, be considered and tackled?

Thank you in advance.

Magarif commented 4 years ago

@joedixon could you, please, provide any feedback on this request?

rw4lll commented 4 years ago

@Magarif I have the same issue. I fixed it by adding route prefix for this route group to my fork. You can look here: https://github.com/rw4lll/nova-translation/blob/master/routes/api.php. At first sight it works ok, but may be I missed something. I made a PR together with several additions bugfixes from me and other people. Hope, it will be merged to this repo in the future.

Magarif commented 4 years ago

@rw4lll thank you for the info. I would consider this project abandoned. Will check out your fork.