search

joel-g / animal-facts-bot

A very important bot that does the very important job of educating the public about animals.
http://reddit.com/u/animalfactsbot/comments
33 stars 187 forks source link

add squid facts #385

Open AJDurant opened 5 years ago

AJDurant commented 5 years ago

I thought that squid was not included, but it turned out there were facts, but they were not being used! I hope this wasn't deliberate...

mpentler commented 5 years ago

Hey Andy,

I was taking on duties for a while to maintain the code but lately I’ve had no time at all to concentrate on it. There are some errors depending on what commit you’re based off, and missing animals from the list that holds the names may be one of them as I trimmed etc.

As soon as I can get some time I’ll have a look and see if I can tidy some things up.

Thanks, Mark

Sent from my iPhone

On 25 Oct 2019, at 22:33, Andy Durant notifications@github.com wrote:



I thought that squid was not included, but it turned out there were facts, but they were not being used! I hope this wasn't deliberate...

You can view, comment on, or merge this pull request online at:

https://github.com/joel-g/animal-facts-bot/pull/385

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/joel-g/animal-facts-bot/pull/385?email_source=notifications&email_token=AGVA4P7SZBZYWE22VV5TFRLQQNQ4BA5CNFSM4JFJLB52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUPUQSQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGVA4P32TC7CRK7YMKYA5CTQQNQ4BANCNFSM4JFJLB5Q.

AJDurant commented 5 years ago

Hi Mark, thanks for the info. I updated my fork from master before work on these PRs, so it should be current, I last contributed quite a while ago.