search

joelagnel / bpfd

BPFd (Deprecated, please see README.md) : Berkeley Packet Filter daemon (BPFd). Makes it possible to run BCC tools across systems.
Apache License 2.0
95 stars 23 forks source link

Update the build system to use CMake instead of just Makefiles #24

Closed jcanseco closed 6 years ago

jcanseco commented 6 years ago

This PR is dependent on PR #23.

joelagnel commented 6 years ago

I see you did update the instructions, so that's good. I will further review this PR once you can update the PR where you do the restructuring and then refresh this one.

jcanseco commented 6 years ago

I went ahead and rebased this branch on top of 'restructure' from PR #23 so that it contains all the requested changes from that PR. It seemed like an easy change so I went ahead and did it.

joelagnel commented 6 years ago

Rebase on master again. Stale commits are again appearing in your PR list

jcanseco commented 6 years ago

Made the requested changes. PTAL.

joelagnel commented 6 years ago

Why didn't you delete the old Makefile(s)? Please submit a follow up PR with that. I am merging this one.