search

joelgriffith / navalia

A bullet-proof, fast, and reliable headless browser API
https://joelgriffith.github.io/navalia/
GNU General Public License v3.0
957 stars 33 forks source link

`exists` shouldn't throw when a timeout is used #36

Closed joelgriffith closed 7 years ago

joelgriffith commented 7 years ago

Currently, exists will wait up to 10 seconds for the element to appear. If it's not there, the timer runs out and Navalia will throw. When a timer is being utilized, exists should "catch" the timeout error and return false, which is the spirit of this API (true when present, false if not).

joelgriffith commented 7 years ago

This should be functioning properly in 0.2.x