search

joelpt / sidewise

Persistent sidebar extension for Chrome featuring tree style tabs and tab hibernation.
Creative Commons Zero v1.0 Universal
68 stars 13 forks source link

YouTube pause button not working on OS X #63

Open jonhermansen opened 8 years ago

jonhermansen commented 8 years ago

Chrome 44.0.2403.155 (64-bit) OS X 10.10.5

With Sidewise enabled, I am unable to pause videos on youtube.com. There are mentions on userecho.com of other Sidewise issues with YouTube as well.

I was able to work around this issue by changing content_script.js, on line 11:

function setUpMediaMonitors(){injectPageScriptSendEventFn();injectYouTubeMonitoring();injectVimeoMonitoring();injectPageScript(jwPlayerEmbedScript);injectPageScript(html5VideoScript)}

to

function setUpMediaMonitors(){injectPageScriptSendEventFn();injectVimeoMonitoring();injectPageScript(jwPlayerEmbedScript);injectPageScript(html5VideoScript)}

So it's clear that this is due to the page monitoring code that is specific to Youtube. Disabling the option "Show current playback time on video pages" doesn't seem to help either. I also checked on a Windows set up and this problem doesn't seem to occur. In all cases the HTML5 player was being loaded, and http://youtube.com/html5 reports all browsers as fully supported HTML5 video playback.

This does not seem to affect embedded YouTube videos on other sites, I would guess because most sites are embedding the Flash player.

Let me know if I can provide any more information. I'm new to Chrome extensions but I can try to dig in deeper if needed.

jonhermansen commented 8 years ago

Can I do anything to help fix this bug? Open sourcing the project would make it easier for me to contribute. I'd happily send a pull request for this.

joelpt commented 8 years ago

I think this should be fixed in the latest release. Please take a look and let me know whether the issue still persists.

Regarding open sourcing: I want to do this but I need to clean a few areas of the code up first.

saintwolf commented 8 years ago

For anyone who is interested, I have created a fork of the project at https://github.com/saintwolf/sidewisefork

Unfortunately due to licensing issues, you are not allowed to publish any of the code to the Chrome store, so it's a bit of a non-starter, but it's the best we can get if the owner isn't willing to fully open-source it.