js agent freebsd

[GoogleCodeExporter]

Hi there, 

here is a small line to add in order to make freebsd compliant with js agent: 

Index: src/system_commands.js
===================================================================
--- src/system_commands.js      (revision 1644)
+++ src/system_commands.js      (working copy)
@@ -33,6 +33,7 @@
   'darwin': UNIX_,
   'linux': UNIX_,
   'unix': UNIX_,
+  'freebsd': UNIX_,
   'win32': WIN32_};

 var commands = {};

-- 
Regis A. Despres

Original issue reported on code.google.com by regis.de...@gmail.com on 21 Dec 2012 at 9:57

[GoogleCodeExporter]

Can't believe everything else just works;) will add of course.
Nice to see freebsd love!

Original comment by k...@google.com on 21 Dec 2012 at 10:34

• Added labels: Component-agent-desktop, OpSys-Linux, Priority-Medium, Type-Enhancement

[GoogleCodeExporter]

hey !

Glad to know =)

err regarding "everything just works" that's not quite already the case =)
 - there's some few patch i have to sendpr in order to get chromedriver  compiled w/gcc46 (not tried w/clang yet): 
   - patch-chrome__test__webdriver__webdriver_automation.cc
   - patch-content__public__test__browser_test_base.cc
   - patch-third_party__mongoose__mongoose.c
 - there is some *sic* /bin/bash all around i've bypassed by ln -s =)

And for now : 

 - basically i'm facing same issues that in #127
 - with flash plugin i can't get screenshot working (blank) but i'm not able for now to see wether it's on webdriver side or chrome itself

Regards,

-- 
Regis A. Despres  

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 12:10

[GoogleCodeExporter]

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 4:09

Attachments:

• patch-chrometestwebdriver__webdriver_automation.cc
• patch-contentpublictest__browser_test_base.cc
• patch-third_partymongoosemongoose.c

[GoogleCodeExporter]

Btw i've installed x11vnc to see how chrome works into xvfb xorg and flash is 
visually working.

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 4:09

[GoogleCodeExporter]

here is some debug info

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 4:20

Attachments:

• debug.log
• chromedriver.log

[GoogleCodeExporter]

and the associated result.

let me know if and how can i give an hand on this one.

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 4:24

Attachments:

• result.tgz

[GoogleCodeExporter]

i might populate the issue #127 with those too =)

Original comment by regis.de...@gmail.com on 22 Dec 2012 at 4:27

[GoogleCodeExporter]

regarding the freebsd+flash blank screenshot issue :
 - i've tested with webdriverjs standalone same issue ; i'll fill a issue on github for this one.

Original comment by regis.de...@gmail.com on 23 Dec 2012 at 9:56

[GoogleCodeExporter]

Committed the system_commands change as r1652. Also changed the script shebang 
lines to #!/bin/sh, which I believe should work on BSD -- please check.

Good to hear that at least the flash screenshot issue is not my fault;) Thanks 
for doing the standalone test.

Also, for the chromedriver patch please file a chromium issue -- I am not a 
chromium committer, they'll need to review and commit.

Original comment by k...@google.com on 29 Dec 2012 at 7:15

• Changed state: Fixed

[GoogleCodeExporter]

Hi there !

#!/bin/sh is luxury but i'll check for safety.

For the record i've also checked a little bit more "deep" with selenium curl 
and x11vnc , it also have same strange behavior. moreover flash screenshot 
works on most sites, some don't. i need to qualify before fill  a bug report @ 
selenium.

Regarding the chromedriver patch , i know you're not in charge =) I've posted 
those for the community record.
I know from xp how "long" that some patch, etheir on fbsd and chrome side can 
be integrated so ... 
Btw, someone that have some "fbsd spirit" (=]) could try with those here.

Original comment by regis.de...@gmail.com on 29 Dec 2012 at 9:55

[GoogleCodeExporter]

It should probably be a chromium bug, since it's specific to
Chrome+chromedriver.

Yeah... I suspect what they would care about the most when looking at your
patch, is a non-regression of their primary supported platforms -- Windows,
Linux, OSX. BTW are there any special instructions to build chromedriver
such that it won't build the whole chromium?:) I wanted to hack on it a bit
myself.

Original comment by k...@google.com on 30 Dec 2012 at 5:56

[GoogleCodeExporter]

Ha, apparently replying to a bug via email strips all quoted text. Let me 
report with the quotes.

> For the record i've also checked a little bit more "deep" with selenium curl 
and x11vnc , it also have same strange behavior. moreover flash screenshot 
works on most sites, some don't. i need to qualify before fill  a bug report @ 
selenium.

It should probably be a chromium bug, since it's specific to 
Chrome+chromedriver.

> Regarding the chromedriver patch , i know you're not in charge =) I've posted 
those for the community record.
> I know from xp how "long" that some patch, etheir on fbsd and chrome side can 
be integrated so ...
> Btw, someone that have some "fbsd spirit" (=]) could try with those here.

Yeah... I suspect what they would care about the most when looking at your 
patch, is a non-regression of their primary supported platforms -- Windows, 
Linux, OSX. BTW are there any special instructions to build chromedriver such 
that it won't build the whole chromium?:) I wanted to hack on it a bit myself.

Original comment by k...@google.com on 30 Dec 2012 at 6:00

[GoogleCodeExporter]

Hi there,

I didn't mentionned it but i've made also those test w/firefox without any luck 
=/

Regarding the fbsd chromedriver patches, as is , they are intentionally made 
for fbsd and its port system, i didn't pay attention to be other os compliant. 

For the compilation instructions and in order to be a bit quicker than "compile 
all things" you might try  a fresh 8 stable as the 9 stable & release online 
package system do not contain chromium binaries.
Afterwhat some hints :
setenv PACKAGESITE 
ftp://ftp.XX.freebsd.org/pub/FreeBSD/ports/i386/packages-8-stable/Latest/  # 
where XX is your nearest location (i.e. us uk ...)
pkg_add -r xorg-vfbserver  node-devel subversion openjdk6 bash chromium firefox
make -C /usr/ports/www/npm config install clean # check node-devel dependency
#copy those 3 patch above into /usr/ports/www/chromium/files/
# modify /usr/ports/www/chromium/Makefile w/ s/ALL_TARGET=     
chrome/ALL_TARGET=     chromedriver/
make -C /usr/ports/www/chromium 
# symlink the missing lib  with the latest present (might be libpcre from what 
i remember)
# copy the 
/usr/ports/www/chromium/work/chromium-courgette-redacted-23.0.1271.97/out/Releas
e/chromedriver into your path and in the webpagetest lib 
(lib/webdriver/chromedriver/`uname -m`/) 

Cheers,

-- 
Regis A. Despres

Original comment by regis.de...@gmail.com on 30 Dec 2012 at 4:28

[GoogleCodeExporter]

If FF has this issue as well, then it could be flash itself or X, but I
really doubt that anything in the selenium tree has much to do with it. The
nodejs agent launches chromedriver directly in recent builds, without even
an intermediate java selenium server. The WDJS client only marshals a
base64 screenshot string from the chromedriver back to the agent, which
does work for non-flash pages.

Michael
Sent from my mobile device

Original comment by k...@google.com on 31 Dec 2012 at 2:54