Undo Restore Point

[GoogleCodeExporter]

In Hard and Very Hard puzzles, sometimes you run out of logical choices. At 
that point you have to make a guess at a value and then try to complete. If you 
guess wrong then you have to either keep undoing back to the guess point or 
start over and build to that point again and try the other value. I would like 
to see 2 buttons added to the menu. "Set Undo Point" - This would flag the last 
undo point in the list with an undo set point flag. You could do this multiple 
times (a single IsUndoPoint property in an Undo class that I assume exists so 
that any undo instance could be flagged as an undo point). "Undo back to Set 
Point" - when clicked would do consecutive undos back to the last set point (or 
all of them if there are no set points in the undo list). I realise that screen 
realestate is at a premium so the button names are more of a description of 
what the menu button would do than the actual text.

I was going to take a stab at it but ran into an issue. I am new to java (ok, 
this would have been my first java code, 26 years programming so new language 
isn't much of a hindrance), I did successfully (maybe?) get a copy of the 
source from svn. The problem is that it is looking for the 
"cz.romario.opensudoku.R" package(class?) but I can't seem to find it.

Original issue reported on code.google.com by thex...@gmail.com on 13 Jul 2010 at 5:43

[GoogleCodeExporter]

Just read the Issues list and noticed that my request has a similar goal to 
#106. This might be more easily added though (hint, hint ;-)

Original comment by thex...@gmail.com on 13 Jul 2010 at 5:48

[GoogleCodeExporter]

I've added this functionality locally. Would you be interested in adding it to 
the Official version? I hope so because I would hate to have to redownload the 
source and modify every time you release a new version ;-)  I have a document 
describing the changes and also could zip up the modules I've changed. The 
changes are minimal.

Original comment by thex...@gmail.com on 13 Oct 2010 at 5:11

[GoogleCodeExporter]

Hello, I would be happy to include this. Can you attach the changed files and 
the document to this issue? I will have a look at it and merge it.

Original comment by romario...@gmail.com on 17 Oct 2010 at 12:47

• Changed state: Accepted

[GoogleCodeExporter]

Thanks. Attached is a zip containing all the code modules affected and 2 .txt 
files. The "Notes" file contains more of a discription of the changes and the 
"Changes" file actually has a copy of the code lines I added.  Also, except for 
the String resource XML, the code is preceeded with "// MJA" comments so it 
should be easy to do a search to find the changes (You don't need to keep these 
in the release :-).  I am a couple releases behind so it may necessitate a 
manual change instead of a merge. Couple things may need to be cleaned up. I 
didn't create icons for the menu options, you may want to do that.  I also put 
the menu options on the first screen for easy access but you may not like the 
new placements. I am new to opensource so if there is a formal procedure that 
is encourged, I apologize for not doing so.

Original comment by thex...@gmail.com on 18 Oct 2010 at 6:23

Attachments:

• OpenSudoku_UndoFlag_Code.zip

[GoogleCodeExporter]

OK, thanks, I will look into it and merge it.

Original comment by romario...@gmail.com on 18 Oct 2010 at 7:56

[GoogleCodeExporter]

Issue 129 has been merged into this issue.

Original comment by romario...@gmail.com on 6 Nov 2010 at 1:56

[GoogleCodeExporter]

Your changes are merged in trunk. I tweaked names a little ("undo checkpoint" 
instead of "undo flag") and did some minor changes / adjustments.

Original comment by romario...@gmail.com on 6 Nov 2010 at 2:18

[GoogleCodeExporter]

Thanks. I see that you changed Command from an interface to a base class. I 
really should get around to learning java ;-)

Original comment by thex...@gmail.com on 17 Nov 2010 at 6:27

[GoogleCodeExporter]

Issue 133 has been merged into this issue.

Original comment by romario...@gmail.com on 22 Nov 2010 at 7:02