search

johanclasson / vso-agent-tasks

Build and Release Tasks for Visual Studio Online and Team Foundation Server
MIT License
20 stars 16 forks source link

Add parameter for timeout #38

Closed john-zzzz closed 5 years ago

john-zzzz commented 6 years ago

DBUp supports the .WithExecutionTimeout() property. This should be mapped to an input variable of the task so that scripts which take longer than the default can be supported.

johanclasson commented 6 years ago

The task already dissables the execution timeout. Not with the method your are referring to, but through:

$configuration.ScriptExecutor.ExecutionTimeoutSeconds = 0

My idea was that one could use the overall build/release timeout. Du you think it is important to be able to specify timeouts on each script? Or is perhaps the timeout disabling as I have implemented it not working?

johanclasson commented 5 years ago

I am closing this since I do not think there is any issue with timeouts as currently configured.