search

johanclasson / vso-agent-tasks

Build and Release Tasks for Visual Studio Online and Team Foundation Server
MIT License
20 stars 16 forks source link

Added configurable journal schema name feature #56

Closed CasperWSchmidt closed 5 years ago

CasperWSchmidt commented 5 years ago

Also bumped version to 1.4.0.

I tried to make minimal amount of changes to all scripts.

Fixes #55

I tried running the tests locally, but got a lot of errors about "Describe" not being a function etc. I'm not used to PowerShell scripting so I don't know how to make it run locally :)

johanclasson commented 5 years ago

Nice feature! I have a quite busy schedule at the moment, but will try to review this during the weekend.

Thanks for your effort!

johanclasson commented 5 years ago

The two new test failed with the message The specified schema name "test" either does not exist or you do not have permission to use it. . Apparently there is an open issue at DbUp which targets just that. Since it was not fixed yet (and did not look like it will be fixed anytime soon) i implemented a workaround.

FYI, we had problems reported from some of our users last release, and I did a quick rollback back then. Since this feature builds on that code I want this release to be a mayor one.

Therefore I replaced your bump version-commit to 2.1.0 instead. I will publish this in the marketplace tomorrow after some more testing.

( closes #51 )

CasperWSchmidt commented 5 years ago

I guess your comment refers to the wrong issue? The issue in dbup looks weird. First it is fixed, then rolled back and then applied again? Anyway a short workaround creating the schema before the test should be good 😊