search

johman10 / flood-for-transmission

A Flood (https://github.com/Flood-UI/flood) clone for Transmission
GNU General Public License v3.0
339 stars 33 forks source link

Added support for toggling label when columns checked or not. #501

Closed J0ins08 closed 2 years ago

J0ins08 commented 2 years ago

Toggled 'Enabled' or 'Disabled' label when columns checked or not.

johman10 commented 2 years ago

Hey! Thanks for the PR, but I'm not sure if this kind of behaviour adds any value really. To me, a label for an input indicates what the input represents, not what the current state of the input is. With your suggested approach the label could be interprated as not disabled, so enabled when the checkbox is off. Which I don't think makes things clearer.

With this reasoning I'm closing your PR, but feel free to run your own build with this feature and run it yourself. ;)

Either way, thank you for contributing! It shows that people are interested, which means a lot to me!