johncclayton / charger

USB based interface to iCharger (and others in the future)
8 stars 5 forks source link

READ_REG_COUNT_MAX #2

Open arezd opened 8 years ago

arezd commented 8 years ago

Hello John !

Nice work you've done here. Thank you for your repository.

I am trying to develop a computer interface for the icharger and your code is very helpful.

Just a question : why did you set the const "READ_REG_COUNT_MAX" at the value of 30 ?

You can find it in icharger.cpp.

Many thanks for your answer :)

Cheers !

arezd commented 8 years ago

Hello John !

I guess, you must be busy considering your previous messages.

Can you at least tell me which documentation you used to build this repository.

Many thanks for your answer.

Cheers

johncclayton commented 8 years ago

Hey there / happy you find the code useful. Can't recall why 30 , probably because during testing on my icharger it worked? :-) I ported the icharger Windows C code - that was the basis, so I kinda trusted that as a source of "truth".

johncclayton commented 8 years ago

In terms of documentation, find modbus icharger Junsi and try to locate their visual studio project. That's what I used.

arezd commented 8 years ago

Thank you for your prompt answer. It is very nice to hear from you.

Can you be more specific when you're saying "ported the Windows C code". What does it mean ? I'm currently working with Linux - Fedora.

Just saw the documentation. Very well explained.

One more question :

Arezki

arezd commented 8 years ago

To be more clear : I found the current output variable in "utils.h". I'm wondering if we can automatically modify it.

Something like :

if the cells are under 80% then output current = max output current that the iCharger can deliver else output current must be reduced.

I saw that we can modify it manually from iCharger interface but didnt manage to find how with a computer.

Many thanks Arezki

johncclayton commented 8 years ago

Hi

Yep - look up "porting" on Google, the process of adjusting code from one platform or system to work in the same way on another.

For your second question: sorry, no idea - you'd have to find and read their modbus protocol spec for the icharger

John Clayton, CTO Sent from my iPhone

On 2 Aug 2016, at 20:09, arezki_d notifications@github.com wrote:

Thank you for your prompt answer. It is very nice to hear from you.

Can you be more specific when you're saying "ported the Windows C code". What does it mean ? I'm currently working with Linux - Fedora.

Just saw the documentation. Very well explained.

One more question :

do you think it is possible to automatically limit the current output when the cells are 80% loaded. I didnt find this variables in "utils.h". That is why i'm asking now. Many thanks again.

Arezki

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.