search

johngray1965 / PdfiumAndroidKt

Pdfium Android binding with Bitmap rendering ( >= API 21 )
Other
31 stars 12 forks source link

Using timber causes lint control to fail in projects that do not use timber #6

Closed dorukkangal closed 1 year ago

dorukkangal commented 1 year ago

Can you use android Log class instead of Timber? Because it causes the lint control to fail in the classes we use android.util.Log and gives the following error: timber-lint-error

johngray1965 commented 1 year ago

I add a comment to your PR, I'm thinking about writing some sort of wrapper so we don't force Timber on you, but also still gives users an option to use Timber. Some Interface with default implementation using android Log, so I can implement it with Timber (above the library, so the library doesn't have a dependencies on Timber).

johngray1965 commented 1 year ago

I remove Timber from the library, and made a wrapper that uses Android Log by default. The sample app still use Timber, and provides an example of to config the library to use something other than the default.

johngray1965 commented 1 year ago

Closing

johngray1965 commented 1 year ago

1.0.13 has been pushed to maven, but it usually takes about 1/2 hour before it is available.

dorukkangal commented 1 year ago

It is working. Thank you for the quick reply!