search

johnny-quesada-developer / easy-web-worker

This is a library to easily handle and create web-workers, if you are a web developer and never tried this... do not wait any longer! Workers are an amazing option to improve user experience and make your webpages even greater
MIT License
18 stars 1 forks source link

Suggest not using `substr` and `new Date` #4

Closed gabrielecirulli closed 10 months ago

gabrielecirulli commented 11 months ago

Within the following line, I would suggest replacing the Date allocation with a call to Date.now() and the use of substr (which is deprecated) with the equivalent substring

https://github.com/johnny-quesada-developer/easy-web-worker/blob/6c9b2317c18652c38bcfbf4a8f2d6489b80b677b/src/EasyWebWorkerFixtures.ts#L2

johnny-quesada-developer commented 10 months ago

Hi @gabrielecirulli, you are absolutely right! substr has been marked as legacy, so I am more than happy to implement your suggestion in version 4.0.3.

Thank you so much for taking the time to review it and, hopefully, for giving the package a try.

I haven't prepared a contribution readme yet, but I will do so soon. In the meantime, please feel welcome to share any ideas or collaborations that could improve this package and help it reach more people.

Regards, and again, thank you so much.

johnny-quesada-developer commented 10 months ago

suggestion was implemented and published in version 4.0.3