search

johno / furtive

A forward-thinking, lightweight, css microframework
http://furtive.co
MIT License
613 stars 40 forks source link

Pseudo-elements use old syntax #40

Closed variadico closed 9 years ago

variadico commented 9 years ago

Hello! Furtive calls itself a "forward-thinking" microframework.

But, I noticed that pseudo-elements in this project use the obsolete syntax (according to MDN). https://developer.mozilla.org/en-US/docs/Web/CSS/::before

For example, here. https://github.com/johnotander/furtive/blob/master/css/furtive.css#L426

Could it be reasonable to update the syntax from foo:before to foo::before? I can submit a pull request if that would help.

johno commented 9 years ago

Thanks for reporting this. That would be absolutely wonderful, @pi241a !

johno commented 9 years ago

Closed with #41

variadico commented 9 years ago

Just pointing out that your latest commit, Add red buttons, re-introduced the old syntax for pseudo-elements.

FYI.

johno commented 9 years ago

Thanks for pointing this out @variadico, I'll swap the syntax out today.

johno commented 9 years ago

Latest version now uses the new syntax.