johnpapa / vscode-peacock

Subtly change the color of your Visual Studio Code workspace. Ideal when you have multiple VS Code instances, use VS Live Share, or use VS Code's Remote features, and you want to quickly identify your editor.
MIT License
1.03k stars 115 forks source link

Choosing colors from the command pallette shows "Activating Extensions" in the notification bar, and doesn't ever change colors #511

Open tcaruth opened 1 year ago

tcaruth commented 1 year ago

I'm not sure where to collect logs that might show what's going on any better. The "Activating Extensions" notitifaction only pops up when I run Peacock commands though, and doesn't seem to be actually doing anything.

johnpapa commented 1 year ago

Thank you @tcaruth for creating this issue!

tcaruth commented 1 year ago

Version - v4.2.2

willpower232 commented 1 year ago

Under Help you can get to Developer Tools which can reveal some information but it can get pretty messy in there but might be useful.

I would presume it is some kind of conflict with another extension so might be worth seeing which other extensions you have that do things with the .vscode/settings.json file

tcaruth commented 1 year ago

Thanks @willpower232

I checked my settings.json file in the workspace and it looks like Peacock is the only thing that's written to it. I've used this extension for months, and only recently started a new workspace that I can't set colors to. New workspaces aren't getting a .vscode/settings.json file created when I choose a color, but one is generated when i use another extension that saves settings to the workspace (for example, https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker). Even after that other extension creates the file (and I assume sets permissions on it) Peacock isn't writing any of the color customizations to the file

Current settings.json in an old workspace

{
    "workbench.colorCustomizations": {
        "activityBar.activeBackground": "#005498",
        "activityBar.background": "#005498",
        "activityBar.foreground": "#e7e7e7",
        "activityBar.inactiveForeground": "#e7e7e799",
        "activityBarBadge.background": "#ff008d",
        "activityBarBadge.foreground": "#e7e7e7",
        "commandCenter.border": "#e7e7e799",
        "sash.hoverBorder": "#005498",
        "statusBar.background": "#003865",
        "statusBar.foreground": "#e7e7e7",
        "statusBarItem.hoverBackground": "#005498",
        "statusBarItem.remoteBackground": "#003865",
        "statusBarItem.remoteForeground": "#e7e7e7",
        "titleBar.activeBackground": "#003865",
        "titleBar.activeForeground": "#e7e7e7",
        "titleBar.inactiveBackground": "#00386599",
        "titleBar.inactiveForeground": "#e7e7e799"
    },
    "peacock.color": "#003865"
}
siriousje commented 1 year ago

I have the same issue, shift-command-p -> surprise me with a random color. the only effect is in the status bar where it says 'Activating Extensions...' with a small spinner and that then just stops. With DevTools open nothing in console image image

maximedelvaux commented 1 year ago

Hi ! I had the exact same issue (version 4.2.2) and disabling the Live Share extension fixed it.

damienleroux commented 1 year ago

Disabling Live Share extension works for me too 🙏 thx @maximedelvaux

siriousje commented 1 year ago

Can confirm, disabling live share fixed it.

spencerb02 commented 1 year ago

Thanks for opening this issue. I've had this issue for a while as well but only on a corporate protected laptop. I thought it was their fault...

Disabling Live Share worked for me as well. But why?!

mckelveygreg commented 1 year ago

Oh my... I've been having issues with live share, but I can't see how they might be related! Removing live share fixed it for me as well 🤷

duke8585 commented 1 year ago

+1 for me, too. anyone know why that is the case? or how to setup debugging in order to find out how...

kianenigma commented 1 year ago

+1 and https://github.com/johnpapa/vscode-peacock/issues/516 https://github.com/johnpapa/vscode-peacock/issues/526 https://github.com/johnpapa/vscode-peacock/issues/523

All seem duplicates of this.

Swanzor commented 1 year ago

Disabling live share made it work for me too. Has anyone got any idea why this is happening?