johnrhimawan / pe

0 stars 0 forks source link

Able To Add Monthly Contributions Higher Value Than Income #4

Open johnrhimawan opened 1 year ago

johnrhimawan commented 1 year ago

image.png

Steps to reproduce: add n/John Tester p/12345678 e/johntester@gmail.com a/Kent Ridge i/100000 m/200000 r/Medium ip/Savings Plan c/CURRENT

I was able to add a person with the income of 100000 and monthly contribution of 200000. I believe that this is a feature flaw. It should be not possible for a person to add a monthly contribution higher than what they earn over a year.

nus-se-script commented 1 year ago

Team's Response

The person might be a retiree. Some of our dad's are retired but still invests in financial plans.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, the team did not even specify what the MONTHLY_CONTRIBUTION means. This is still a feature flaw since the financial advisor would be unsure on what it means. It could be how much the financial advisor is charging each client per month or how much the client would want to contribute to investing in a certain portfolio. This makes the definition vague.

Furthermore, it is still a feature flaw if the MONTHLY_CONTRIBUTION is higher value than the YEARLY_INCOME. Taking either possible definition of MONTHLY_CONTRIBUTION, we can see that this MONTHLY_CONTRIBUTION is a consistent payment which requires the financial advisor to be certain of whether the client can pay monthly or not. Even retired individuals have an income in the form of CPF funds, which can be considered as income. It could be a large flaw if the financial advisor opens the application and sees that the client is planning to invest more money in a month than what the client earns in a whole year.