johnwahba / go-tour

Automatically exported from code.google.com/p/go-tour
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

fix image output of local tour #64

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run gotour
2. Go to step 35 - Exercise: Slices
3. Try (x*y) function.

What is the expected output? What do you see instead?
Picture is cut-off at 3/4.

What version of the product are you using? On what operating system?
Fedora 18
Google Chrome Version 29.0.1541.2 dev
go version go1.1.1 linux/amd64
go-tour
changeset:   126:63620f922bb2
tag:         tip
date:        Tue Jun 18 18:14:16 2013 +1000

Please provide any additional information below.
Other functions like (x^y, x+y...) works fine.

Original issue reported on code.google.com by Miroslav...@gmail.com on 25 Jun 2013 at 2:34

Attachments:

GoogleCodeExporter commented 9 years ago
Please include your code.

Original comment by a...@golang.org on 26 Jun 2013 at 5:17

GoogleCodeExporter commented 9 years ago
@1 - It's in the first attachment (code.go).

Original comment by Miroslav...@gmail.com on 26 Jun 2013 at 8:57

GoogleCodeExporter commented 9 years ago
It works for me? Maybe a bad execution got cached. Can you confirm it works for 
you now?

Original comment by a...@golang.org on 27 Jun 2013 at 1:58

GoogleCodeExporter commented 9 years ago
It is still reproducible. I restarted both gotour and operating system. To be 
absolutely clear - I installed gotour onto my system using 'go' tool and I am 
running it locally on my computer. It happens also in Firefox (21.0).

However attached code works fine if I run it on golang.org or tour.golang.org 
webs.

When running it locally, there is line of characters between image and 'Program 
exited.' message. Line starts with: YAxlIAXAqASwFwKQAuBcClALgUAN+e ... it's 
very long (wc says: 1 1 7795).

Original comment by Miroslav...@gmail.com on 27 Jun 2013 at 6:34

GoogleCodeExporter commented 9 years ago
Btw. Attached picture seems to be shorter than original which I sent. Original 
is 3/4 of full size.

Original comment by Miroslav...@gmail.com on 27 Jun 2013 at 6:43

GoogleCodeExporter commented 9 years ago
I see the issue: the output image is being written with several distinct write 
calls, and the javascript on the server side receives them as several distinct 
blobs of data, only the first of which is translated into an image. It'll 
require a bit of plumbing to fix this, but shouldn't be too hard. Thanks for 
the report. 

Original comment by a...@golang.org on 1 Jul 2013 at 2:58

GoogleCodeExporter commented 9 years ago
This should be fixed once this change lands 
https://codereview.appspot.com/12311043

Original comment by a...@golang.org on 2 Aug 2013 at 1:38