Fix `-D interpro` option to correctly include domains in the output plot

joiningdata / lollipops

Lollipop-style mutation diagrams for annotating genetic variations.

GNU General Public License v3.0

182 stars 70 forks source link

Fix `-D interpro` option to correctly include domains in the output plot #83

Closed matthiasblum closed 1 month ago

matthiasblum commented 2 months ago

Hi @pbnjay,

This small PR addresses an issue caused by a recent change in how the representative property is stored in the JSON response when querying InterPro matches for a given UniProtKB accession. The change led to lollipops failing to include any domains in the output plot when the -D interpro option is used.

pbnjay commented 1 month ago

Lgtm!

matthiasblum commented 1 month ago

Thank you for merging, @pbnjay.

Would you mind publishing a new release? Since GoReleaser is configured to use your Apple Developer ID to sign the binary, I wouldn't be able to publish a release with binaries for all OS.

pbnjay commented 1 month ago

Release pushed: https://github.com/joiningdata/lollipops/releases/tag/v1.7.2

Sorry I'm slow, lots going on at the day job lately!