search

joinmarket-webui / jam-docker

https://jamdocs.org
MIT License
14 stars 7 forks source link

The docker run command in the building notes #130

Open Ulawun opened 2 months ago

Ulawun commented 2 months ago

Hello,

this building notes: https://github.com/joinmarket-webui/jam-docker?tab=readme-ov-file#building-notes say three times, that the container is to start with:

docker run --rm -it \ ... joinmarket-webui/jam-ui-only

I think that is not correct ! Shouldn't it be:

docker run --rm -it \ ... ghcr.io/joinmarket-webui/jam-ui-only

theborakompanioni commented 2 months ago

Hey @Ulawun! Thanks for the question! This is the run command when you built the image locally (the instructions above the one you are referring to) - which is preferred to trusting the hosted image from github. Do you have a suggestion how to improve the documentation? Your report is highly appreciated! Thank you. :pray:

theborakompanioni commented 1 month ago

Hey @Ulawun - does the above statement make sense to you? Do you think the issue can be closed or do you have a suggestion regarding documentation changes to make them more clear?

Ulawun commented 1 month ago

Thanks for the answer. In my opinion the documentation can be improved by adding a list of commands to get the container run. I as a non docker expert had to contact the docker community to get the container run.