jojobear13 / shinpokered

Mostly-vanilla hack of Pokémon Red/Blue focused on bugfixes and trainer ai
205 stars 40 forks source link

Request: Version-Based Trade Adjustments #306

Closed Healnavi closed 9 months ago

Healnavi commented 9 months ago

Is your feature Within-Scope of the project? Yes. These changes are suggested to keep the spirit of the original release and consider Pokemon availability in each version.

Describe the feature you would like I would like adjustments to in-game trades based on JP differences and Pokemon availability based on version:

  1. Shin Red JP & Green don't use JP trade nicknames, unlike Shin Blue JP. Please apply JP nicknames to Shin Red JP/Green.

  2. In the 1995 Red JP/Green, the girl in the northern entrance to the Underground Path wants a Nidoran trade, F > M. In the international Red/Blue, she instead wants M > F. Shin Pokemon currently uses the M > F trade for all versions. Further, the original JP version "chains" with a trade at the Route 11 lookout spot, where a boy wants Nidorino for his Nidorina. This trade was not changed in international R/B, so the "chain" only exists in Red JP/Green. Gen III remakes use same gender trades from the international version, but institute a version swap for the Pokemon the player has to offer, choosing whichever is more common in their version. To simplify: [Red JP/Green: F > M > F] | [Red/Blue US + Red Gen 3 + Shin Pokemon: M > F (x2)] | [Green Gen 3: F > M (x2)] Please restore the trade chain to the 1995 versions, where you are able to trade the girl's Pokemon to the boy.

  3. Red version players have to trade away Butterfree for Beedrill in the re-implemented Chikuchiku/Prickly trade on Route 22. This trade is very much not in favor of the player in Red version. Please adjust this trade in Red version to allow the player easier access with their version's equivalent Pokemon.

Describe alternatives you've considered

  1. Add If clause to trades.asm for each version in order to make per-version trade changes, like Blue JP. Restore Japanese nicknames for Red JP and Green trades. (Baribari, Chappy, Namezo, Masako, etc)

  2. Proposed solutions for Nido problem. Personal preference is towards (c. Parity) or (e. Remake Parity): a. Accuracy - Change trade sequence to reflect original games. Only JP versions get trade chain. US has same gender trades. Red JP/Green = [F > M > F]. Red/Blue US = [M > F (x2)]. b. Revision - Change trade sequence so all versions have trade chain; Region-based Nido sequence. Red JP/Green = [F > M > F]. Red/Blue US = [M > F > M]. c. Parity - Change trade sequence so all versions have trade chain. Version swaps the Nidos like the remakes. Red = [M > F > M]. Blue US/Green = [F > M > F]. d. Remake - Change trade sequence; JP gets trade chain. US gets same gender, version swap Nido trades like remakes. Red JP/Green = [F > M > F]. Red US = [M > F (x2)]. Blue US = [F > M (x2)]. e. Remake Parity - JP gets chain, US gets same gender, both version swap. Accurate and player-friendly, but complicated. Red JP = [M > F > M]. Green = [F > M > F]. Red US = [M > F (x2)]. Blue US = [F > M (x2)].

  3. Change Route 22 trade from [Butterfree > Beedrill] to [Beedrill > Butterfree] in Red versions, as Weedle is common. The Butterfree received can be named Hirahira/Fluttery to match Chikuchiku/Prickly. Could alternatively use Pipin, the unused name for Prickly in Red JP/Green.

Additional context Apologies for how long this is, but it's difficult to explain succinctly and I didn't want to flood you with several individual requests. While most of these requests are for the master branch, I would appreciate the seeing the accuracy solution to the Nidoran trades added to the Lite branch, as it's the way the original games handled these trades.

jojobear13 commented 9 months ago
  1. Will use IF statements to compile based on the version's encounter compiler tag. Will not use the Japanese nicknames. Shin Pokemon handles proper nouns in the following priority: Released localization > Released Japanese > Improvise something that fits.

  2. The Nidoran swap was likely a localization error. Will probably go with remake parity as it gives the version differences more flavor.

  3. Will implement for red versions.