jojobear13 / shinpokered

Mostly-vanilla hack of Pokémon Red/Blue focused on bugfixes and trainer ai
205 stars 40 forks source link

Bug: Typos in Green version #339

Open PokefanMarcel opened 4 months ago

PokefanMarcel commented 4 months ago

Reporting a few typos I noticed during my playthrough of ShinGreen:

Pokedex:

Oak dialogue is missing a period:

Orange champion dialogue:

jojobear13 commented 4 months ago

Corrections Made:

Non-Straightforward Corrections:

jojobear13 commented 4 months ago

fixed in commit 9642a9578

PokefanMarcel commented 4 months ago

Just a reminder about the two other typos (Oak and Seiga) since you didn't address those, in case you forgot.

For Dodrio: since 'embodied' was a better wording, you can still make use of word breaks across lines (two choices here, 'em-bod-ied'), the Red/Blue Pokédex entries use them extensively and you have some extra space on the next line. For instance:

_DodrioDexEntry::
    text "An odd and rare"
    next "3-headed species."
    next "Joy, sadness, and"

    page "anger are embod-"
    next "ied in each head"
    next "respectively"
    dex

For Haunter this should work?

_HaunterDexEntry::
    text "If you get the"
    next "feeling of being"
    next "watched in the"

    page "dark when nobody"
    next "is around, a"
    next "HAUNTER is there"
    dex
jojobear13 commented 4 months ago

Good ideas all around. I did forget a few things.

I looked into the Oak dex rating. There already is an exclamation mark, but there is an issue with line length. Each line can have a max of 18 characters including spaces. EXCEPT for the last line before a line scroll because the flashing cursor takes up the 18th space. As you can see below, the cursor overwrites the exclamation point.

Not enough space to hyphenate "entirely" upwards to the top line. I'm open to ideas here. "Wholly"? "Fully"?

image

PokefanMarcel commented 4 months ago

I don't see a good answer either, it's tricky! I would personally prefer to remain conservative in this case, and leave the small typo rather than changing the original translation...

Although if change there must be I guess 'fully' would be the better option.

jojobear13 commented 4 months ago

I think I found a good solution. I discovered an unused text-function character that auto-scrolls the line without a button press or printing the flashing cursor. All I had to do was add in a 30-frame delay so that the first line is legible before it goes away.

ezgif-3-35113a2810

PokefanMarcel commented 4 months ago

Very elegant solution! It looks great.