search

jokade / slogging

A Typesafe-logging (and slf4j) compatible logging library based on macros for Scala/JVM, Scala.js, and Scala Native
MIT License
50 stars 11 forks source link

Agnostic http logger #18

Closed julienrf closed 8 years ago

julienrf commented 8 years ago

These refactorings make it easier to implement a custom HTTP logger. Basically I introduced a LoggerTemplate which has only one abstract method (instead of the 12 methods that you have to implement when you implement AbstractUnderlyingLogger.

I think this LoggerTemplate could superseed the actual AbstractUnderlyingLogger at some point.

julienrf commented 8 years ago

Also note that this PR depends on #17.

julienrf commented 8 years ago

Any feedback on this? @jokade

jokade commented 8 years ago

LGTM, thanks (I've been busy with other things over the last months...sorry for the delay)