jokob-sk / NetAlertX

๐Ÿ–ง๐Ÿ” WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.15k stars 186 forks source link

[Core] Set plugin execution order #722

Closed jokob-sk closed 4 months ago

jokob-sk commented 4 months ago

Is there an existing issue for this?

Am I willing to test this? ๐Ÿงช

Can I help implement this? ๐Ÿ‘ฉโ€๐Ÿ’ป๐Ÿ‘จโ€๐Ÿ’ป

Is your feature request related to a problem? Please describe

  1. Start with plugins which look at the physical layer (like the omada plugin which gets access to the switch/ports)
  2. Do layer 2 with (arp-scan)
  3. Do layer 3 (IP) with ping, DNS, traceroute
  4. Layer 4 and above (nmap, tcping, udp pnp etcโ€ฆ)

Describe the solution you'd like

config.json property

Describe alternatives you've considered

user setting - re-ordering of individual plugins

Anything else?

no

jokob-sk commented 4 months ago

Releasing -> closing

stanelie commented 1 month ago

Hello. How do you set the plugin order? Thanks!

jokob-sk commented 1 month ago

Hi @stanelie , this is done internally by the config.json of individual plugins. Changing the order manually might lead to unpredictable behaviors - I haven't tested it. With the release of #826 - where you can order plugins in the settings, it might be possible, but I haven't tested it.