jokob-sk / NetAlertX

🖧🔍 WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.15k stars 186 forks source link

fixed mylog timezone issue #742

Closed FlyingToto closed 4 months ago

FlyingToto commented 4 months ago

so I was able to fix the timezone issue when the plugin calls mylog by adding the following:

from pytz import timezone
import conf
conf.tz = timezone(get_setting_value('TIMEZONE'))

My guess is that when a plugin gets called by the Nax, it doesn't inherit the proper timzone value and default back to blank. Hence the need to reinitialize it by reloading the value from config... note: trying to add the logic in the looger.py script won't work because it causes a circular reference with the conf file... not worth the effort imho...

gitguardian[bot] commented 4 months ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13089634](https://dashboard.gitguardian.com/workspace/463787/incidents/13089634) | Triggered | Generic High Entropy Secret | c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5 | front/plugins/omada_sdn_imp/omada_sdn.py.0.3 | [View secret](https://github.com/jokob-sk/NetAlertX/commit/c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5#diff-f2f3f8f3a2eba8e48c9a5a625e60a34c50f25cbaeb3f31bd1cc120c3b7e2e503R77) | | [13089636](https://dashboard.gitguardian.com/workspace/463787/incidents/13089636) | Triggered | Generic High Entropy Secret | c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5 | front/plugins/omada_sdn_imp/omada_sdn.py.0.3 | [View secret](https://github.com/jokob-sk/NetAlertX/commit/c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5#diff-f2f3f8f3a2eba8e48c9a5a625e60a34c50f25cbaeb3f31bd1cc120c3b7e2e503R420) | | [13089636](https://dashboard.gitguardian.com/workspace/463787/incidents/13089636) | Triggered | Generic High Entropy Secret | c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5 | front/plugins/omada_sdn_imp/omada_sdn.py.0.3 | [View secret](https://github.com/jokob-sk/NetAlertX/commit/c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5#diff-f2f3f8f3a2eba8e48c9a5a625e60a34c50f25cbaeb3f31bd1cc120c3b7e2e503R74) | | [13089636](https://dashboard.gitguardian.com/workspace/463787/incidents/13089636) | Triggered | Generic High Entropy Secret | c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5 | front/plugins/omada_sdn_imp/omada_sdn.py.0.3 | [View secret](https://github.com/jokob-sk/NetAlertX/commit/c51d1ec00e5b2f9314d643e000b1e2d2516fc9f5#diff-f2f3f8f3a2eba8e48c9a5a625e60a34c50f25cbaeb3f31bd1cc120c3b7e2e503R60) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.