jokob-sk / NetAlertX

🖧🔍 WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.15k stars 186 forks source link

New devices that are offline are not shown as down #816

Closed Jozko568 closed 1 month ago

Jozko568 commented 2 months ago

Is there an existing issue for this?

Current Behavior

NetAlertX banner with Down devices does not show the amount of new down devices even though the graph below does as you can see on the screenshot. I've adjusted the CLEAR_NEW_FLAG to 168 hours so maybe after that the devices will show as Down but I haven't tested this.

image

I don't think that logs are needed for this but if so, I'll happily provide them.

Expected Behavior

The Down banner should always display down devices even for new devices

Steps To Reproduce

  1. Add new devices
  2. Disconnect them from the network
  3. Devices will only show up as new but not as down

app.conf

No response

docker-compose.yml

No response

What branch are you running?

Production

app.log

No response

Debug enabled

jokob-sk commented 1 month ago

Hi @Jozko568 ,

I aligned the colors and split out the Offline / Down count which are different values. Down devices are only devices that are reported as Down (Alert Down is ticked on the device and the device is Offline at the same time)

image

This should be available in the next release. It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first), in about 15 minutes (or after the last action finishes) from now?

Make sure you refresh your browser cache - and click the 🔄 refresh button in the top right corner.

Thanks in advance, j

Jozko568 commented 1 month ago

Thanks for the quick response! I pulled the dev image but I don't have the Offline amount as you do in the gray box under Devices. Is that some setting ? I have cleared the cache but that did not show it.

image

jokob-sk commented 1 month ago

Hey, yes there is a UI_PRESENCE setting to choose what to display.

On Tue, 1 Oct 2024, 16:10 Jozko568, @.***> wrote:

Thanks for the quick response! I pulled the dev image but I don't have the Offline amount as you do in the gray box under Devices. Is that some setting ? I have cleared the cache but that did not show it.

image.png (view on web) https://github.com/user-attachments/assets/cb09db70-0aee-42bb-9147-b3f26f33fb55

— Reply to this email directly, view it on GitHub https://github.com/jokob-sk/NetAlertX/issues/816#issuecomment-2384881018, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5URDFEO2BGOFAMAIAFMX3ZZI4E7AVCNFSM6AAAAABPEBDH6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUHA4DCMBRHA . You are receiving this because you commented.Message ID: @.***>

Jozko568 commented 1 month ago

Ah thanks! It was actually UI_shown_cards which I meant. Seems like the setting did not apply correctly on the first try as I had to save it twice for it to change properly. Managed to replicate it multiple times. I guess I should create a separate issue for that? Other than that, this separation works as expected.

image

image

jokob-sk commented 1 month ago

Great, I don't think I have time to fix this now. It's probably cache related, refreshing the cache should reflect the changes after the first settings change. Would be great if you could help out with a PR though :)

Jozko568 commented 1 month ago

I'd love to but I'm not skilled enough when it comes to programming :( Would like to avoid making "half baked" solution via ChatGPT

jokob-sk commented 1 month ago

Understood, I'll keep it in the backlog, but I don't see it as a functionality breaking bug.

Jozko568 commented 1 month ago

No problem! I'll report it as a new issue so it does not get mixed up. Thanks!