jolars / sgdnet

Fast Sparse Linear Models for Big Data with SAGA
https://jolars.github.io/sgdnet/
GNU General Public License v3.0
5 stars 2 forks source link

Introductory, model family, benchmarks, and technical specification vignettes #16

Closed jolars closed 6 years ago

jolars commented 6 years ago

This pull request adds three vignettes to the package and updates one:

These are still a work in progress so I don't expect to merge this one right now, but I'd love for you to pitch in if you have any feedback.

Edit (18/13/8)

I have now also generated a pkgdown-site for the project, which I intend to link to as the final work product of gsoc.

michaelweylandt commented 6 years ago

This is a good start - I only reviewed the vignettes since I think the other changes are already under review as #15. I particularly appreciated the technical write up - I finally (sort of) get the point of the lagged update structure.

michaelweylandt commented 6 years ago

Did you want another round of comments on this?

jolars commented 6 years ago

Hm, thanks but let's wait a little. I noticed that I had missed seeing to a couple of your comments too.

jolars commented 6 years ago

I'll merge this one in now and upload the pkgdown site.