joltup / react-native-threads

Create new JS processes for CPU intensive work
MIT License
756 stars 142 forks source link

ThreadManager.m uses `jsBundleURLForBundleRoot:fallbackResource`, which no longer exists in RN 68 #147

Open RustyTheBoyRobot opened 2 years ago

RustyTheBoyRobot commented 2 years ago

Using this library in a React Native 0.68 app, I get the following build error in XCode:

/Users/joltdev/code/jolt/universal/node_modules/react-native-threads/ios/ThreadManager.m:23:61: No visible @interface for 'RCTBundleURLProvider' declares the selector 'jsBundleURLForBundleRoot:fallbackResource:'

Based on this comment by a RN dev, it seems that the fallbackResource is gone and should be removed.

RustyTheBoyRobot commented 2 years ago

I can't tell for sure, but this might be the root cause of both of these issues:

jacobp100 commented 2 years ago

I'm working on supporting this over on my fork https://github.com/jacobp100/react-native-webworker

I haven't got Android working yet