jon-turney / pidgin-musictracker

Automatically exported from code.google.com/p/pidgin-musictracker
GNU General Public License v2.0
1 stars 0 forks source link

Show changed status in pidgin status area #174

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This was a feature which I badly wanted since musictracker was born.
After applying the patch, following would be the behavior of musictracker.

When musictracker wants to change any statuses, a new saved status named 
"Musictracker" would be created (if not already created) and the current 
status would be switched to Musictracker.
This status won't be switched to if
a) Status is offline
b) Status is invisible
c) New Status is blank (No music playing and off player status is not set)

This new musictracker saved status would inherit the "type" from the 
currently set status. If it is away, musictracker status would be away as 
well, and if it is busy, musictracker status would be busy and so on.

If "Dont change status message when away" option is selected and the 
current status is away, The status won't be changed.

My earlier plan was to make it as follows:
When user has set a status (whether away or not), don't switch to 
Musictracker status. (This would have prevented musictracker from forcibly 
changing status)
Since a feature "Dont change status message when away" was introduced, i 
tried not to disturb it.

Important Note:
%s in status won't work with this patch as The current playing song is the 
current status and it will get appended with %s. Please do something about 
it. My suggestion is to remove this %s tag altogether for the following 
reasons:
If a message is to be appended or inserted anywhere in the status, user can 
directly type that message instead of %s. As the content of %s doesn't 
change with every song, it doesn't make sense to have a tag.
e.g I want to show my song as Nothing Else Matters - Metallica - Shaving
I can directly use "%t - %p - Shaving" instead of "%t - %p - %s"

Final Note: This patch has not been tested thoroughly. This is just for 
demo purposes. Please try it and give feedback so that it can be altered to 
suit needs.
Thanks.

Original issue reported on code.google.com by anup.ara...@gmail.com on 2 Oct 2009 at 7:10

GoogleCodeExporter commented 9 years ago
Use this patch instead. Fixed a bug when track info is null, Status was 
forcefully 
being changed to Musictracker.

Original comment by anup.ara...@gmail.com on 3 Oct 2009 at 6:32

Attachments:

GoogleCodeExporter commented 9 years ago
When "Change status to Away on Idle" setting is turned on in pidgin, once user 
went 
idle and came back, musictracker status type changed to "Away" irrespective of 
what 
status was present before goin idle.
Fixed the issue in this patch.

Original comment by anup.ara...@gmail.com on 4 Oct 2009 at 10:09

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks very much for the patch, it's really appreciated.   This is something 
that's
needed fixing for a long time.

Sorry I haven't have a chance to look at it until now.

Original comment by b152fee4...@gmail.com on 27 Nov 2009 at 10:50

GoogleCodeExporter commented 9 years ago
For those who are lazy to apply the patch and build, I have built two versions 
of the 
plugin with source from latest svn plus the feedback_status patch - one for x86 
and 
other for amd64. (Check attachment)
x86 was compiled on an Ubuntu 8.04 32bit machine
amd64 was compiled on gentoo amd64 machine.

Try the plugin.
Extract the binaries to /usr/lib/pidgin

Original comment by anup.ara...@gmail.com on 19 Dec 2009 at 7:14

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by b152fee4...@gmail.com on 13 Jan 2010 at 2:04

GoogleCodeExporter commented 9 years ago
Thanks very much for the patch.  I've tidied a few things up and merged it with 
some
similar work I had done, so it now deals with %s correctly.

The major problem with it as it stands is that setting the savedstatus seems to 
set
the status message for all accounts, so this completely ignores any custom 
formatting
or disable per account which might have been set in musictracker.  It's 
possible that
could be fixed using substatuses.

Original comment by b152fee4...@gmail.com on 10 Mar 2010 at 2:45

Attachments:

GoogleCodeExporter commented 9 years ago
Setting the saved status is just for display purposes for the user. In my 
previous 
version of the patch at least, any custom formatting works fine. The saved 
status area 
shows the global status while custom status gets applied for individual 
accounts and 
other users see the custom status for respective accounts.
I didn't check it with the latest patch. Will check it soon.

Original comment by anup.ara...@gmail.com on 10 Mar 2010 at 7:12