search

jonashaag / klaus

docker run klaus / pip install klaus — the first Git web viewer that Just Works™.
http://klausdemo.lophus.org
Other
685 stars 102 forks source link

Handle SymrefLoop #295

Closed jelmer closed 2 years ago

jelmer commented 2 years ago

Handle SymrefLoop. Fixes: #293

jonashaag commented 2 years ago

Why aren’t actions running? :(

jonashaag commented 2 years ago

Can you please rebase latest master

jonashaag commented 2 years ago

WDYT about having the tuple (KeyError, SymrefLoop) defined as a constant somewhere and using that instead of repeating the list of exceptions everywhere? Could also have a short comment there what’s SymrefLoop.

jelmer commented 2 years ago

WDYT about having the tuple (KeyError, SymrefLoop) defined as a constant somewhere and using that instead of repeating the list of exceptions everywhere? Could also have a short comment there what’s SymrefLoop.

Happy to define a shorthand for those two places where we catch both (InaccessibleRef, perhaps?). That said, I'm wary of using that everywhere - e.g. in views.py where a message to the user saying a ref doesn't exist is quite different from saying the ref is broken.

jelmer commented 2 years ago

Updated.

jonashaag commented 2 years ago

Perfect!