Fix some issues reported by ruff

jonashaag / klaus

docker run klaus / pip install klaus — the first Git web viewer that Just Works™.

http://klausdemo.lophus.org

Other

685 stars 102 forks source link

Fix some issues reported by ruff #314

Closed jelmer closed 1 year ago

jelmer commented 1 year ago

In particular:

use def rather than assigning lambda function
unused imports
'X not in Y' vs 'not X in Y'

jonashaag commented 1 year ago

What’s your option on the lambda vs def rule? I don’t like it but have no strong opinion.

If you want to add ruff, black, etc to the CI feel free to!

jelmer commented 1 year ago

What’s your option on the lambda vs def rule? I don’t like it but have no strong opinion.

I don't have a particularly strong opinion either way, but since other tooling (ruff, pycodestyle) seems to prefer def over assigning lambdas I'm inclined to just go with that.