search

jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
908 stars 50 forks source link

charset is a bit controversial #51

Closed madrus closed 1 year ago

madrus commented 1 year ago

Suggestion

charset is a bit controversial as a parameter. It produces something like this:

<meta charset="UTF-8">

It looks like it is a meta parameter but it has to be added as a separate attribute:

<SEO charset='UTF-8'
...
/>

My suggestion is to either add it to the extend meta section or to write about it being a separate <SEO /> attribute in the README.

jonasmerlin commented 1 year ago

Hey @madrus, can you maybe elaborate on this a bit? How does this behavior differ from e.g. the description property, which also produces a <meta> tag?

jonasmerlin commented 1 year ago

Closing this because of inactivity for now. Feel free to reopen it should it still be relevant.