search

jonathanchu / emacs-powerline

Powerline for Emacs
497 stars 37 forks source link

Generate arrow images of variable size #19

Closed katspaugh closed 11 years ago

katspaugh commented 11 years ago

Hi Jonathan!

I would like to have arrows of size 12x24 (to match the Monaco font at height 18), so I thought it would be nice to make these arrows' size dependent on the mode-line font-face.

This is the first step – a function to generate XPM templates. Please confirm whether it is an acceptable direction of development.

katspaugh commented 11 years ago

cc @WHOISJohnGalt

ghost commented 11 years ago

Yeah, this is much better than my dumb pull request.

jonathanchu commented 11 years ago

This looks great at first glance @katspaugh! Let me take a deeper dive into this this weekend and I'll get back to you /cc @WHOISJohnGalt

Thanks so much!

katspaugh commented 11 years ago

It seems @winterTTr has already written some well structured utilities for generating triangles in the mode-line: https://github.com/winterTTr/emacs-of-winterTTr/blob/master/.emacs.d/wttr-config/wttr-mode-line.el

Doh, the same issue has also been already addressed in the proposed version 2 from #13.

jonathanchu commented 11 years ago

@katspaugh When you get a chance, would you mind leaving or emailing me your full name so I can add to AUTHORS? If not, I'll just add your GitHub handle. :)

katspaugh commented 11 years ago

Hey Jonathan! Thanks! Glad you had time to review it.

Username is OK, thank you.