search

jonathanchu / emacs-powerline

Powerline for Emacs
497 stars 37 forks source link

Arrow shape fixed in case of even modeline height #21

Closed ancane closed 9 years ago

ancane commented 11 years ago

Hi! I have found small issue in get-arrow-dots function. The result of calling (get-arrow-dots 'left 6 12) was

\".     \",
\"..    \",
\"...   \",
\"....  \",
\"..... \",
\"......\",
\"..... \",
\"....  \",
\"...   \",
\"..    \",
\".     \",
\"      \"

The problem is that this arrow is asymmetrical and it wasn't pixel perfect when rendered in modeline - that looked a bit ugly to me.

But from now on, (get-arrow-dots 'left 6 12) generates the following:

\".     \",
\"..    \",
\"...   \",
\"....  \",
\"..... \",
\"......\",
\"......\",
\"..... \",
\"....  \",
\"...   \",
\"..    \",
\".     \"

Arrow is symmetrical now and looks perfectly. Thank you.

jonathanchu commented 11 years ago

Hi @ancane! Thanks so much for the patch - let me test with a few different size fonts and will merge if all looks good. That was the one issue I encountered early on...arrows didn't look good with smaller fonts, but most of it has been cleaned up :)

jonathanchu commented 9 years ago

:+1:

Apologies on the major delay in merging this. This is great - thank you for the great work on this. :beers:

ancane commented 9 years ago

Np :) Thank you @jonathanchu for the merged PR!