search

jonathansick / ads_bibdesk

(Unmaintained) Mac OS X service for frictionless import of NASA ADS and arXiv publications into BibDesk.
GNU General Public License v3.0
37 stars 20 forks source link

add the option for specifying the ssh-proxy port / improve python2/3 compatibility #72

Closed r-xue closed 6 years ago

r-xue commented 6 years ago

The code seems to be work for AAS journals and MNRAS now ( via both the local or proxy method). I am gradually moving my literature collections from Papers3 to BibDesk. If I notice something else broken, I will bring it up to you or try to patch it directly.

keflavich commented 6 years ago

Is this ready to merge? I wish we had a test suite... I have no idea whether this is going to break anything for me... but thanks for doing the tests and contributing this!

r-xue commented 6 years ago

I hope so... well my literature collection exported from Papers3 is diverse enough and are technically being used as the "test suite" for me... btw, I didn't submit the change for the service .workflow file.

keflavich commented 6 years ago

What changes did you make there? Might they be generally useful? I've inherited maintenance responsibility for this project, so there's a lot about the code base I don't understand fully yet.

r-xue commented 6 years ago

from my understanding (see CONTRIBUTING.md), just need to run: 

python setup.py service
keflavich commented 6 years ago

Oh, right, you're saying the workflow changed when you ran the install script, but you didn't commit that? Sounds fine.

keflavich commented 6 years ago

Alright, I'm merging this, but I may have to revert if I discover bugs...

r-xue commented 6 years ago

sounds good!