jonathanslenders / ptpdb

prompt_toolkit/ptpython pdb frontend
181 stars 20 forks source link

ptpdb ships with no modules installed. #2

Closed jonathanslenders closed 9 years ago

jonathanslenders commented 9 years ago

When installing from Pypi.

cc: @RonnyPfannschmidt : Sorry, I did not had the time yet. I'll try to fix things asap.

Grokzen commented 9 years ago

@jonathanslenders Noticed this also. Installing from source works for now atleast :]

msabramo commented 9 years ago

Just ran into this as well.

msabramo commented 9 years ago

I think all that is needed at this point is to bump the version and upload a tarball as it looks like the issue is no longer there on master.

A download from PyPI has no modules:

[marca@marca-mac2 ptpdb]$ tar tvzf ptpdb-0.1.tar.gz
drwxrwxr-x  0 jonathan jonathan    0 Dec 11 10:50 ptpdb-0.1/
drwxrwxr-x  0 jonathan jonathan    0 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/
-rw-rw-r--  0 jonathan jonathan   15 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/requires.txt
-rw-rw-r--  0 jonathan jonathan  266 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/PKG-INFO
-rw-rw-r--  0 jonathan jonathan    1 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/top_level.txt
-rw-rw-r--  0 jonathan jonathan    1 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/dependency_links.txt
-rw-rw-r--  0 jonathan jonathan  163 Dec 11 10:50 ptpdb-0.1/ptpdb.egg-info/SOURCES.txt
-rw-rw-r--  0 jonathan jonathan  375 Dec 11 10:49 ptpdb-0.1/setup.py
-rw-rw-r--  0 jonathan jonathan  266 Dec 11 10:50 ptpdb-0.1/PKG-INFO
-rw-rw-r--  0 jonathan jonathan   12 Dec 11 10:49 ptpdb-0.1/README.rst
-rw-rw-r--  0 jonathan jonathan   59 Dec 11 10:50 ptpdb-0.1/setup.cfg

but a freshly built sdist does:

[marca@marca-mac2 ptpdb]$ tar tvzf dist/ptpdb-0.1.tar.gz
drwxr-xr-x  0 marca  staff       0 Feb 15 17:31 ptpdb-0.1/
-rw-r--r--  0 marca  staff     266 Feb 15 17:31 ptpdb-0.1/PKG-INFO
drwxr-xr-x  0 marca  staff       0 Feb 15 17:31 ptpdb-0.1/ptpdb/
-rw-r--r--  0 marca  staff    9308 Feb 15 14:02 ptpdb-0.1/ptpdb/__init__.py
-rw-r--r--  0 marca  staff    2541 Feb 15 14:02 ptpdb-0.1/ptpdb/commands.py
-rw-r--r--  0 marca  staff    3321 Feb 15 14:02 ptpdb-0.1/ptpdb/completers.py
-rw-r--r--  0 marca  staff    1111 Feb 15 14:02 ptpdb-0.1/ptpdb/completion_hints.py
-rw-r--r--  0 marca  staff    2503 Feb 15 14:02 ptpdb-0.1/ptpdb/grammar.py
-rw-r--r--  0 marca  staff     686 Feb 15 14:02 ptpdb-0.1/ptpdb/key_bindings.py
-rw-r--r--  0 marca  staff     966 Feb 15 14:02 ptpdb-0.1/ptpdb/layout.py
-rw-r--r--  0 marca  staff     947 Feb 15 14:02 ptpdb-0.1/ptpdb/style.py
-rw-r--r--  0 marca  staff    1646 Feb 15 14:02 ptpdb-0.1/ptpdb/toolbars.py
drwxr-xr-x  0 marca  staff       0 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/
-rw-r--r--  0 marca  staff       1 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/dependency_links.txt
-rw-r--r--  0 marca  staff      47 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/pbr.json
-rw-r--r--  0 marca  staff     266 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/PKG-INFO
-rw-r--r--  0 marca  staff       9 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/requires.txt
-rw-r--r--  0 marca  staff     357 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/SOURCES.txt
-rw-r--r--  0 marca  staff       6 Feb 15 17:31 ptpdb-0.1/ptpdb.egg-info/top_level.txt
-rw-r--r--  0 marca  staff     453 Feb 15 14:02 ptpdb-0.1/README.rst
-rw-r--r--  0 marca  staff      59 Feb 15 17:31 ptpdb-0.1/setup.cfg
-rw-r--r--  0 marca  staff     421 Feb 15 14:02 ptpdb-0.1/setup.py
s-y commented 9 years ago

Please, update version on pypi.

Grokzen commented 9 years ago

+1 on update

jonathanslenders commented 9 years ago

Hi all, thanks for reminding me. I did a new update on pypi. (both of prompt-toolkit and ptpython.) Sorry for the delay!

Please could you run "pip install ptpython" and tell me whether it works?

iho commented 9 years ago

Hi @jonathanslenders .
I ask for update only ptpdb becasue version on PYPI do not work

➜  ~  ptpython      
In [1]: from ptpdb import set_trace                                             
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <module>
ImportError: No module named ptpdb
No module named ptpdb

In [2]:                                                                         

Version ptpdb on https://github.com/jonathanslenders/ptpdb working ok.

jonathanslenders commented 9 years ago

Oh, sorry. I should have been confused last night. I didn't update ptpdb. Doing in now.

edit: Ok. I need to do a few more changes to make it compatible with the latest prompt-toolkit. I'll do it later today.

jonathanslenders commented 9 years ago

I did a new release of ptpdb. Can you try to install it?

iho commented 9 years ago

@jonathanslenders

import ptpdb
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <module>
  File "/home/ihor/.pyenv/versions/2.7.8/lib/python2.7/site-packages/ptpdb/__init__.py", line 26, in <module>
    from prompt_toolkit.contrib.shortcuts import create_eventloop
ImportError: cannot import name create_eventloop
cannot import name create_eventloop

also

pip install ptpdb -U
# skiped 
  Found existing installation: ptpdb 0.1
    Uninstalling ptpdb-0.1:
      Successfully uninstalled ptpdb-0.1

Successfully installed prompt-toolkit-0.31 ptpdb-0.2 ptpython-0.5
jonathanslenders commented 9 years ago

Ok. We need ptpython 0.6 and prompt-toolkit 0.32. I don't know why they still had a dependencies to these old versions.

In any case. I did a new release. Try again. pip install -U ptpdb.

iho commented 9 years ago

You do not increase version number so pip install -U ptpdb use cached version. I remove ~/.cache/pip and install new ptpdb.

ptpython 
In [1]: import ptpdb                                                                                                           

In [2]: ptpdb.set_trace()                                                                                                      
--Return--
> <string>(1)<module>()->None
(pdb)                      

Looks nice :+1:

jonathanslenders commented 9 years ago

Ok, thank! :)

Well, I still have to put some more effort in this tool. This was a proof of concept, and my main focus was more on the underlying libraries (prompt-toolkit and ptpython). Probably when these become more stable and feature complete, I will have time again to improve this. :) Cheers.