search

jonathanyeung / mark-sharp

Mark Sharp WYSIWYG Markdown Editor for VS Code
44 stars 0 forks source link

Image is not rendering properly #36

Closed thruthesky closed 2 weeks ago

thruthesky commented 1 month ago

Describe the bug.

When there is a space in the path of the image, it produces x-box.

See the video below;

https://github.com/user-attachments/assets/2b30c8e3-5057-4ffa-a75e-fd85c1580d15

Repro Steps

  1. Copy and paste the image into README. It will generate automatic name like image (2).png, image (3).png, ...
  2. Put the image into TABLE. And there is error.

Fix: When I remove the space in the file name the error disappears. For instance, renaming image (2).png to image(2).png.

Version

1.5.1

What platform are you seeing the problem on?

Mac OS

thruthesky commented 1 month ago

I found out a symtom;

If image.png andimage (1).png exists, it will prompts the folder location two times; It has something to do with the automatical numbering.

jonathanyeung commented 1 month ago

Thanks for reporting the issue @thruthesky - I'll take a look.

jonathanyeung commented 3 weeks ago

Hi @thruthesky - images with spaces and angled brackets should render properly in tables in the latest update 1.6.0. Let me know if you're still hitting issues.

thruthesky commented 2 weeks ago

It's working as expected. Thank you