search

jonborg / ThumbnailGenerator

This is a Thumbnail Generator for Super Smash Ultimate VODs. It was created to help the portuguese community of Smash Ultimate. However, with some tinkering, it can be used to create VODs of other tournaments. Improvements are being made to enable customization of tournament list.
2 stars 0 forks source link

Incorrect scaling of Chrom mural art in thumbnail #55

Open JoVoStudios opened 2 months ago

JoVoStudios commented 2 months ago

Whenever Chrom is chosen in a thumbnail with mural arts enabled, he is way too upscaled compared to his frame and not at all visible in the thumbnail itself. This is the case both for the left and right side of the thumbnail SIL _ JVsaadi-king_dedede2--Lancelot-chrom1--ROUND ROBIN POOLS-Trondheim Smash Saga #1

JoVoStudios commented 2 months ago

Managed to fix this myself in the settings of my local repository, although it should probably be pushed to an official release as well. Adjusted to these values in ThumbnailGenerator_v3_0_0\settings\thumbnails\images\defaultMural.json if anyone else is looking for the same fix: { "fighter": "chrom", "offset": [ -180, 120 ], "scale": 0.5 },

jonborg commented 1 month ago

Hello JoVoStudios,

Sorry for answering you so late. Thank you for reporting this issue! I am currently refactoring how scales and offsets are used, but I can still use your solution to calculate the new scales and offsets for Chrom! I will be sure to include your fix in the next version!