search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.82k stars 383 forks source link

Ver 0.83.17 SDL1 conflicts with JohnGlassmyer/UltimaHacks #2782

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug Latest official SDL1 version from this repo conflicts with Ultima Underworld hacks for Ultima Underworld 1 found here https://github.com/JohnGlassmyer/UltimaHacks/tree/master/uw1

When pressing ` to switch between mouse lock and unlock modes , it goes in an infinite loop alternating between mouse lock and unlock.

The version I am using is from 11/17/2020 4:46 PM and is SDL1 and works perfectly. Strange thing is conf says is 0.83.7 where as this new one says 0.83.17. Odd!

EDIT: Just did a quick test using the provided binaries and is indeed an SDL1 issue only.
SDL2 build works as intended.

Somehow SDL build alters something about the DOS or DosBox keyboard calls making some UltimaHacks key presses fall into an infinite loop.

To Reproduce You need an Ultima Hacks patched version from the repo above then start the game and try to change to mouse lock mode pressing `

Environment (please complete the following information): Windows 10 21H1 latest current release from this repo 0.83.17 I have my own dosbox-x.conf that appears to be simpler than this release.

maron2000 commented 3 years ago

Hi, I think this may be regarding a same bug. Can you refer to my comment in the following link? https://github.com/joncampbell123/dosbox-x/issues/2770#issuecomment-894794802

ghost commented 3 years ago

My computer is currently on the fritz cannot look into this. However it does seem related. The issue is grave doesn't provide a keyup message? That would explain the infinite loop.

maron2000 commented 3 years ago

I assume so, and I tested the patch with my Japanese keyboard and seems to fix it. I wanted some other people (especially non-JP keyboards) to check if it works as well.

Edit: Some new patch is available. https://github.com/joncampbell123/dosbox-x/issues/2770#issuecomment-894906248

ghost commented 3 years ago

Just tested the latest release same issue. I assume perhaps it has been merged but not yet released officially. I'll see about next version.