search

jongacnik / kirby-fields-block

Kirby block preview plugin to directly render block fields
MIT License
109 stars 5 forks source link

Add margin-top to block container #15

Closed medienbaecker closed 1 year ago

medienbaecker commented 1 year ago

Thanks for merging my PR with the style improvements. I just noticed it's not ideal when people combine regular WYSIWYG blocks with fields blocks so I added an additional margin to the top that collapses when two fields blocks meet. What do you think?

CleanShot 2023-01-17 at 22 31 17@2x

medienbaecker commented 1 year ago

I also updated the preview images in the README:

jongacnik commented 1 year ago

Hi, really appreciate all the work put in here. I actually decided to revert back to no margins for now, to maintain parity with default block spacing.

medienbaecker commented 1 year ago

I certainly would have appreciated some kind of discussion.

In my opinion the rounded corner does not work without spacing. Using the same border radius for parent and child is also not in line with Kirby's design. But it's your plugin after all.

CleanShot 2023-01-23 at 10 46 05@2x

I would however suggest mentioning the toggle arrow in the README.