search

jonhoo / faktory-rs

Rust bindings for Faktory clients and workers
Apache License 2.0
204 stars 16 forks source link

Use static dispatch in FaktoryCommand's issue #39

Closed rustworthy closed 10 months ago

rustworthy commented 10 months ago

This change is Reviewable

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (481b152) 70.0% compared to head (829d069) 70.0%.

Additional details and impacted files | [Files](https://app.codecov.io/gh/jonhoo/faktory-rs/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/proto/single/cmd.rs](https://app.codecov.io/gh/jonhoo/faktory-rs/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3Byb3RvL3NpbmdsZS9jbWQucnM=) | `96.4% <80.0%> (ø)` | |
rustworthy commented 10 months ago

static for libs and dynamic for bins :)

This part, though, is not user-facing and looks like staying with dynamic dispatch will also be just fine, but then unused type param can be removed

jonhoo commented 10 months ago

I'll hold off on releasing this until https://github.com/jonhoo/faktory-rs/pull/34 lands.

jonhoo commented 10 months ago

Released in 0.12.2 :tada: