Add support for focusing video

jonom / jquery-focuspoint

jQuery plugin for 'responsive cropping'. Dynamically crop images to fill available space without cutting out the image's subject. Great for full-screen images.

Other

3.15k stars 211 forks source link

Add support for focusing video #30

Closed g-van-vreckem closed 8 years ago

g-van-vreckem commented 9 years ago

see #28 9567f69 Looks simple no? However:

The jQuery 'or' selector overhead for 'img, video' seems wasteful.
It's of course intended only for video with no controls.
There are platform issues with transform of videos, it should stick to the no transform path.

So it would probably best to implement that in some other way. Like using a different class (focuspoint-video) with different defaults

g-van-vreckem commented 9 years ago

Addressed the issues mentioned above see #28 9567f69 and 606faf1

xat commented 9 years ago

is video really a valid use-case for this plugin? I wouldn't try to feature-bloat it too much.

g-van-vreckem commented 9 years ago

Actually I'm using that feature. And with a bit reworking separating setup and resize there will be no impact on perf and code size. On Sep 23, 2014 1:12 AM, "Simon Kusterer" notifications@github.com wrote:

is video really a valid use-case for this plugin? I wouldn't try to feature-bloat it too much.

— Reply to this email directly or view it on GitHub https://github.com/jonom/jquery-focuspoint/issues/30#issuecomment-56457543 .

fnagel commented 8 years ago

+1 for video support!

jonom commented 8 years ago

Possible in v2 (in development)