search

jonschlinkert / vertical-rhythm

Put some typographical vertical rhythm in your CSS. LESS, Stylus and SCSS/SASS versions included.
https://github.com/jonschlinkert
MIT License
86 stars 13 forks source link

Bootstrap 3.0 support? #3

Open cviebrock opened 11 years ago

cviebrock commented 11 years ago

Just wondering if you've looked at the vertical-rhythm settings since BS3 was released. I know that they've changed some of their .less files and class names, and added some new components (e.g. panels) that would be affected by vertical rhythm.

jonschlinkert commented 11 years ago

this wasn't really created with Bootstrap support in mind, but I can update classes if it helps out.

Which classes in particular would be affected? The vast majority of the styles in this component are element selectors rather than classes, and the differentiating aspect of this component is nested in the .rhythm class. So rather than trying to maintain compatibility, maybe I should just remove the "base" section altogether? what are your thoughts?

cviebrock commented 11 years ago

Not sure. I only downloaded BS3 yesterday and haven't been digging into it much yet.

Personally, it would be "nice" to be able to @import(vertical-rhythm.less) into my Bootstrap stack and have everything magically fixed. :wink:

Let me play some more and see how it works with BS3. As you said, since it's mostly affecting elements rather than classes, it's probably just fine and I'm jumping the gun with my issue request.

jonschlinkert commented 11 years ago

it's probably just fine

Maybe, but I would love to know how it turns out for you. Please let me know and I'd be happy to update.

it would be "nice" to be able to @import(vertical-rhythm.less) into my Bootstrap stack and have everything magically fixed.

I'm a fan of this as well!

cviebrock commented 11 years ago

Well, one issue I just noticed is that you should probably comment out the two variable definitions in the less file:

@font-size-base:       14px;
@line-height-base:     20px;

If I'm importing that file, it's going to overwrite any custom variable definitions I made previously. Does that make sense?

jonschlinkert commented 11 years ago

Makes perfect sense. I'll probably do as you suggested, but let me think about alternatives as well.

cviebrock commented 11 years ago

Fair enough. If it helps, I'll put up my workflow for customizing BS. It's mostly based on https://github.com/divshot/themestrap .. using Grunt to handle the builds and source paths.

jonschlinkert commented 11 years ago

sounds great, thanks.

jonschlinkert commented 11 years ago

to just think out loud and let you know what's on my mind. For a while now I've wanted to find a better way to solve the issue(s) we're discussing here, not for just this project per se, but for LESS in general. I think part of the solution will be the conventions we use for including external less files, but it goes beyond that. Anyway, I'll just get this fixed per your suggestions when I have a chance, and we'll go from there. (btw, thanks for pointing out themestrap, they use a project I created, assemble, for building the HTML.)