Soft FEC decoding for burst 10500bps

[jeroenbeijer]

Hi Jonti! Here are the proposed changes to allow soft FEC decoding for 10500bps burst using libcorrect. The draft burst 1200bps MSK is also there but very much work in progress. I have disabled this code in the ui.

[jontio]

Hi Jeroen,

Thank you for the pull request. With git all I have really done so far has been pulling and pushing to my own repos so merging your code with mine and collaborating will be a learning experience for me.

From my side I see the commits you have done since you forked my code. I can also view all your commits as if they were just one commit. When you make new commits from now on I see them too, I think. I see three different types of merges "merge commit", "squash merge", and "rebase and merge"; I don't understand what rebasing is.

I've had a very quick look at the changes you've made but it will take me some time to review everything you have done as I have a few other projects that I desperately want to get finished before the end of the year. I believe that I can comment on individual lines of the code so we can discuss if the change was a good thing or not; so I think this will be a handy feature.

My style is ...

if(a==b)
{
    qDebug()<<"test";
}
 else
 {
    qDebug()<<"other";
 }

if(c==d){qDebug()<<"test; return 1;}

If find that the easiest to read.

As your code has some testing for burst 1200 I'm thinking of creating a new branch that you code is merged into rather than the master. I'll have to figure out how to create a new branch but once I've done that I believe that you can edit the branch that this pull request points to ( https://github.com/blog/2224-change-the-base-branch-of-a-pull-request ).

I'll keep you posted.

Cheers, Jonti

[jontio]

I just created a "dev" branch and realized that I too can choose were it goes, so have switched it to the dev branch.

[jontio]

Hi Jeroen,

I've have a cursory look and tried out the 1200 burst with your samples. It's great to see the 1200 burst signals being decoded. I noticed that the EbNo is not calibrated for the different shape of the 1200 signals and is reporting low. As I recall I calibrated/tested the other signals with the help of signals I created in matlab to make sure ebno was reading correctly in pure AWGN. In burstmskdemodulator.h #include "biquad.h" is needed to be removed before the program will compile. The libcorrect.a or libcorrect.dll.a (I can't remember which) is/are needed for static builds but people can build these themselves.

I can't clone your repo and make the changes and send a pull request back to you but I'll see if I merge your pull request into the dev branch of mine whether I can change things there and send you a pull request. That will be interesting as I don't know if I will continue to see your commits as I have been doing over the last few months.

Cheers, Jonti