search

jonwagner / EventSourceProxy

EventSourceProxy (ESP) is the easiest way to add scalable Event Tracing for Windows (ETW) logging to your .NET program
Other
97 stars 20 forks source link

NuGet -> Futures? #31

Closed Mike-E-angelo closed 9 years ago

Mike-E-angelo commented 9 years ago

Just a thought here. I am thinking it would be better to name "NuGet" to "Futures", as that is what the Microsoft.Diagnostics.Tracing.EventSource is. If interested, I have a commit here: https://github.com/Michael-DST/EventSourceProxy/commit/2767ab4e12abaa6fc77586ecf73f8397848e8792

I also made an improvement with how the files are namespaced. That is, there were ifdefs around the namespace (EventSourceProxy.NuGet), when the namespace can be just the same as the "Present" assembly (EventSourceProxy).

Obviously, this is a breaking change for current code... and would be something to consider for future version.

I can send a pull request if you'd like. No worries if not, otherwise. Just a thought/suggestion. :)

Mike-E-angelo commented 9 years ago

A few more notes:

Latest commit is here: https://github.com/Michael-DST/EventSourceProxy/commit/46cae81791d90c03b6cb89a00cc357c39cfaf097

jonwagner commented 9 years ago

I merged your code changes in, but I didn't rename the package. I'm not sure how to redirect the packages in NuGet. (I'm also wary of calling it "Futures", since everything seems to be going in NuGet now.)