jonwagner / Insight.Database

Fast, lightweight .NET micro-ORM
Other
859 stars 145 forks source link

Adding transaction isolationlevel overloads #434

Closed lawrencek76 closed 4 years ago

lawrencek76 commented 4 years ago

Description

Adds overloads that take an isolationlevel and pass to the transaction being created.

Checklist

Please make sure your pull request fulfills the following requirements:

Type

This pull request includes what type of changes?

Breaking Changes

Does this pull request introduce any breaking changes?

Any other comment

resolves #430

lawrencek76 commented 4 years ago

@jonwagner Should SqlConnectionStringBuilderExtensions class be moved from the Insight.Database.Configuration project into Insight.Database.Providers.Default? I am not sure what other issues that may cause if any. This would allow adding the overloads of openwithtransaction that are sqlconnection specific to those extensions. Otherwise it looks like we would need to add a dependency to Insight.Database.Configuration from Insight.Database.Providers.Default and not sure how you would want to handle that.

jonwagner commented 4 years ago

Those dependencies could probably use a cleanup.

Now that the new sql package is Microsoft.Data.SqlClient, it's probably worth breaking out all of the providers and dependencies, and bump to version 7 so everyone can clean up all of the package refs. will look at all of this next.