Open DelPoint opened 2 years ago
Hm. Looks like this is a duplicate of #36957.
Well, the #36957 is a very similar issue, but not this case. In this case custom icons are added by selecting images, AND the alt text is still wrong, because the code inserting the image uses COM_CONTACT_EMAIL key.
It seems to me COM_CONTACT_EMAIL is used in /com_contact/src/View/Contact/HtmlView.php only.
2 possible solutions: use the JGLOBAL_EMAIL
or add _LABEL
as done in https://github.com/joomla/joomla-cms/issues/36957
None of those icons should have an ALT description at all as they are purely decorative so they should be alt=""
@brianteeman Well, then #36976 was pointless, and both components/com_contact/tmpl/contact/default_address.php and components/com_contact/src/View/Contact/HtmlView.php ...must be edited/fixed too, plus we can remove the already added lang strings from _com_contact.ini used by these 2 files, I guess.
On the other hand: ALT can be helpful (decorative img or not), as that can be used if something went wrong with the images - e.g. you are using an img file with space(s) in its name: just test it, it will produce invalid SRC value in IMG tag (another bug BTW in HtmlView.php).
@DelPoint this is an abuse of the alt text, unfortunately it was used this way in the past.
Today we know that Alt texts give information for blind users, they are read by screen readers. No blind user must hear an announcement like "image DGB-78589980988-int-1000x456.png".
Steps to reproduce the issue
Expected result
Alt text should display the word Email instead of the key CON_CONTACT_EMAIL of the missing lang string.
Actual result
System information (as much as possible)
Joomla! 4.1.2., but earlier versions are also affected.
Additional comments
Lang file "com_contact.ini" needs to be updated & translated with a new string COM_CONTACT_EMAIL="Email"